feat: continue local history with current API - #1903
Open
undefinted wants to merge 5 commits into
Open
Conversation
undefinted
force-pushed
the
feat/continue-local-history-with-current-api
branch
from
August 19, 2026 15:45
34ee009 to
ea19b94
Compare
BigPizzaV3
previously requested changes
Aug 20, 2026
BigPizzaV3
left a comment
BigPizzaV3
left a comment
Owner
There was a problem hiding this comment.
成功后，代码先执行重命名并对失败直接 返回，只有重命名成功才设置 。因此只要 暂时不受当前 app-server 支持或超时，就已经创建了 fork，却向界面报告失败且不标记可见；用户重试会继续创建隐藏/重复 fork。建议将“创建并标记可见”作为主事务路径，重命名降级为 warning（或提供可回滚清理），并补充重命名失败不产生重复误导的测试。另外标题先拼接短 ID 再截断 160 字符，长标题会把用于区分的短 ID 截掉，应先为后缀预留长度。
BigPizzaV3
requested changes
Aug 20, 2026
BigPizzaV3
left a comment
BigPizzaV3
left a comment
Owner
There was a problem hiding this comment.
thread/fork 成功后，代码先执行重命名并对失败直接返回，只有重命名成功才设置 has_user_event。因此只要 thread/name/set 暂时不受当前 app-server 支持或超时，就已经创建了 fork，却向界面报告失败且不标记可见；用户重试会继续创建隐藏或重复 fork。建议将创建并标记可见作为主路径，重命名降级为 warning，或提供可回滚清理，并补充重命名失败场景的测试。另外标题先拼接短 ID 再截断 160 字符，长标题会把用于区分的短 ID 截掉，应先为后缀预留长度。
…istory-with-current-api # Conflicts: # apps/codex-plus-launcher/src/main.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / 概要
new-<original-title>-<short-thread-id>for clear identification.new-<原始标题>-<短会话 ID>，便于区分。codex.cmdshim when available.codex.cmdshim 解析 CLI 执行。openainow reads as "显示 API 登录历史" and maps API-provider local history back to the official-login provider.openai时显示为「显示 API 登录历史」，并将 API provider 的本地历史归到官方登录 provider。Behavior / 行为
openaiprovider. It does not copy API keys, merge cloud accounts, or upload local secrets.openaiprovider 下打开；不会复制 API Key、合并云端账号，也不会上传本地密钥。Validation / 验证
npm.cmd test -- --runInBand(66 passed)cargo check -p codex-plus-launchercargo test -p codex-plus-core --test cdp_bridge(109 passed)git diff --checkrun_provider_sync_with_target(..., Some("openai")).run_provider_sync_with_target(..., Some("openai"))将 API provider 历史映射回官方登录。git diff --cached --checkpassed before commit; sensitive-pattern scan of the submitted diff found no GitHub credentials, passwords, API keys, server password, or local.codexdata.git diff --cached --check通过；提交 diff 的敏感信息扫描未发现 GitHub 凭据、密码、API Key、服务器密码或本地.codex数据。